mvtc empty #7348
Open
mvtc empty #7348
+1,105
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JdbcType implements SimpleConvert - PropertyType implements SimpleConvert - ColumnInfo implements SimpleConvert - Unit implements SimpleConvert
- JdbcType implements SimpleConvert - PropertyType implements SimpleConvertmake JdbcType.CHAR.convert() consistent with JdbcType.VARCHAR - ColumnInfo implements SimpleConvert - Unit implements SimpleConvert
I'm not sure if the current callers handle FIELD_MARKER???.
update DomainKind.hasNullValues() to handle empty arrays, also a faster version.
XingY
reviewed
Jan 23, 2026
| return new SqlSelector(ExperimentService.get().getSchema(), blankRowsSQL).exists(); | ||
| } | ||
|
|
||
| if (getTotalAndNonBlankSql(domain, prop, allRowsSQL, nonBlankRowsSQL)) |
Contributor
There was a problem hiding this comment.
For non-provisioned domain, why do we need a second check if getBlanksSql(domain, prop, blankRowsSQL) is false?
Contributor
Author
There was a problem hiding this comment.
I think there may be a case where the domain supports provisioning (null != getStorageSchemaName()), but no table has been created yet (null == domain.getStorageTableName()).
In that case both methods could return false. I just tried to keep the flow mostly the same.
Comment on lines
1347
to
1350
| } final String name = col.getName(); | ||
|
|
||
|
|
||
|
|
| @Override | ||
| public boolean isEmpty(Object value) | ||
| { | ||
| if (null == value) |
Contributor
There was a problem hiding this comment.
Should we check for JSONArray to be consistent with other places?
NOTE: the refactor of the ConvertHelper is in another change list. I removed it from this PR to simplify it.
XingY
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
For Array type required does not mean "IS NOT NULL" it means "cardinality() > 0".
Also for Multiple-choice text we prefer that null/"" converts to [] not to null.
To help implement this we consolidate column conversion into ColumnInfo.convert() and required/non-empty checking into JdbcType.isEmpty().
Related Pull Requests
Changes